From 0887af3018dc1e12bc8f60e8159f9dda8a04b629 Mon Sep 17 00:00:00 2001
From: Romain GALMIER <rgalmier@takima.fr>
Date: Tue, 24 Sep 2024 18:12:50 +0200
Subject: [PATCH] refacto: Improve Syntax
---
README.md | 4 ++--
src/main/java/takima/test/kataagregio/model/ParkType.java | 4 +++-
src/main/java/takima/test/kataagregio/model/TimeBlock.java | 1 -
.../test/kataagregio/persistance/impl/TimeBlockDaoImpl.java | 1 +
.../takima/test/kataagregio/presentation/OfferController.java | 1 -
.../takima/test/kataagregio/presentation/dto/OfferDto.java | 1 -
.../takima/test/kataagregio/utils/mapper/ParkDtoMapper.java | 3 +--
.../test/kataagregio/utils/mapper/TimeBlockDtoMapper.java | 4 +---
8 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/README.md b/README.md
index 5967ba8..a52f02d 100644
--- a/README.md
+++ b/README.md
@@ -42,8 +42,9 @@ To run the application you can run it on an Ide or use the following command:
The application will be available on the following url: http://localhost:8081
### Stack
+
- Java 21 last LTS
-- Spring Boot framework web
+- Spring Boot framework web
- Hibernate
- Postgres
- Docker
@@ -89,7 +90,6 @@ Use Dto for the response of creation of offers
Add validation for the creation of parks and offers with the creation of associated exceptions
-
#### Database
Need to do indexes on the relevant columns in order to improve the performance of the application
diff --git a/src/main/java/takima/test/kataagregio/model/ParkType.java b/src/main/java/takima/test/kataagregio/model/ParkType.java
index c8e73ed..ea5525b 100644
--- a/src/main/java/takima/test/kataagregio/model/ParkType.java
+++ b/src/main/java/takima/test/kataagregio/model/ParkType.java
@@ -1,5 +1,7 @@
package takima.test.kataagregio.model;
public enum ParkType {
- SOLAR, WIND, HYDRO,
+ SOLAR,
+ WIND,
+ HYDRO,
}
diff --git a/src/main/java/takima/test/kataagregio/model/TimeBlock.java b/src/main/java/takima/test/kataagregio/model/TimeBlock.java
index d530e60..d408801 100644
--- a/src/main/java/takima/test/kataagregio/model/TimeBlock.java
+++ b/src/main/java/takima/test/kataagregio/model/TimeBlock.java
@@ -12,7 +12,6 @@ public class TimeBlock {
@Id
@GeneratedValue(strategy = GenerationType.UUID)
private UUID id;
-
private double amountMw;
private double minimumPrice;
private Instant startTime;
diff --git a/src/main/java/takima/test/kataagregio/persistance/impl/TimeBlockDaoImpl.java b/src/main/java/takima/test/kataagregio/persistance/impl/TimeBlockDaoImpl.java
index 44adee1..41ecae6 100644
--- a/src/main/java/takima/test/kataagregio/persistance/impl/TimeBlockDaoImpl.java
+++ b/src/main/java/takima/test/kataagregio/persistance/impl/TimeBlockDaoImpl.java
@@ -10,4 +10,5 @@ import java.util.UUID;
@Repository
public interface TimeBlockDaoImpl extends JpaRepository<TimeBlock, UUID>, JpaSpecificationExecutor<TimeBlock>, TimeBlockDao {
+
}
diff --git a/src/main/java/takima/test/kataagregio/presentation/OfferController.java b/src/main/java/takima/test/kataagregio/presentation/OfferController.java
index 4b37abf..6d585b4 100644
--- a/src/main/java/takima/test/kataagregio/presentation/OfferController.java
+++ b/src/main/java/takima/test/kataagregio/presentation/OfferController.java
@@ -1,7 +1,6 @@
package takima.test.kataagregio.presentation;
import jakarta.validation.Valid;
-import org.springframework.validation.annotation.Validated;
import org.springframework.web.bind.annotation.*;
import takima.test.kataagregio.model.Offer;
import takima.test.kataagregio.presentation.dto.OfferDto;
diff --git a/src/main/java/takima/test/kataagregio/presentation/dto/OfferDto.java b/src/main/java/takima/test/kataagregio/presentation/dto/OfferDto.java
index bad4b0f..0ea75c4 100644
--- a/src/main/java/takima/test/kataagregio/presentation/dto/OfferDto.java
+++ b/src/main/java/takima/test/kataagregio/presentation/dto/OfferDto.java
@@ -1,6 +1,5 @@
package takima.test.kataagregio.presentation.dto;
-
import java.util.List;
public class OfferDto {
diff --git a/src/main/java/takima/test/kataagregio/utils/mapper/ParkDtoMapper.java b/src/main/java/takima/test/kataagregio/utils/mapper/ParkDtoMapper.java
index 832f7d9..1fccaf9 100644
--- a/src/main/java/takima/test/kataagregio/utils/mapper/ParkDtoMapper.java
+++ b/src/main/java/takima/test/kataagregio/utils/mapper/ParkDtoMapper.java
@@ -5,7 +5,6 @@ import takima.test.kataagregio.model.Park;
import takima.test.kataagregio.presentation.dto.ParkDto;
import java.util.List;
-import java.util.stream.Collectors;
@Component
public class ParkDtoMapper {
@@ -29,7 +28,7 @@ public class ParkDtoMapper {
public List<ParkDto> toDtoList(List<Park> parks) {
return parks.stream()
.map(this::toDto)
- .collect(Collectors.toList());
+ .toList();
}
}
diff --git a/src/main/java/takima/test/kataagregio/utils/mapper/TimeBlockDtoMapper.java b/src/main/java/takima/test/kataagregio/utils/mapper/TimeBlockDtoMapper.java
index c8511c1..94168ba 100644
--- a/src/main/java/takima/test/kataagregio/utils/mapper/TimeBlockDtoMapper.java
+++ b/src/main/java/takima/test/kataagregio/utils/mapper/TimeBlockDtoMapper.java
@@ -4,8 +4,6 @@ import org.springframework.stereotype.Component;
import takima.test.kataagregio.model.TimeBlock;
import takima.test.kataagregio.presentation.dto.TimeBlockDto;
-import java.util.stream.Collectors;
-
@Component
public class TimeBlockDtoMapper {
private final ParkDtoMapper parkDtoMapper;
@@ -23,7 +21,7 @@ public class TimeBlockDtoMapper {
timeBlock.setEndTime(dto.getEndTime());
timeBlock.setParks(dto.getParks().stream()
.map(parkDtoMapper::fromDto)
- .collect(Collectors.toList()));
+ .toList());
return timeBlock;
}
--
GitLab