From 13b51cd195c863522a2bbebb08b5793656b132d1 Mon Sep 17 00:00:00 2001
From: Damien MARCHAT <dmarchat@takima.fr>
Date: Mon, 10 Mar 2025 17:24:23 +0100
Subject: [PATCH] Commented parts in the signal exercise that would not compile
during working on day 1 exercises
---
.../signals/InventoryActivity.java | 5 ++--
.../signals/InventoryWorkflow.java | 8 ++---
.../temporalpractice/signals/MSMain.java | 30 +++++++++++--------
3 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/src/main/java/io/takima/temporalpractice/signals/InventoryActivity.java b/src/main/java/io/takima/temporalpractice/signals/InventoryActivity.java
index 0f9daf8..cdf59f8 100644
--- a/src/main/java/io/takima/temporalpractice/signals/InventoryActivity.java
+++ b/src/main/java/io/takima/temporalpractice/signals/InventoryActivity.java
@@ -1,7 +1,6 @@
package io.takima.temporalpractice.signals;
-
-
-@ActivityInterface
+// TODO : remove comments when starting the mastering signals exercise
+//@ActivityInterface
public interface InventoryActivity {
void reserve(ConsumeSignal input);
diff --git a/src/main/java/io/takima/temporalpractice/signals/InventoryWorkflow.java b/src/main/java/io/takima/temporalpractice/signals/InventoryWorkflow.java
index 7e7cd5b..df18b5d 100644
--- a/src/main/java/io/takima/temporalpractice/signals/InventoryWorkflow.java
+++ b/src/main/java/io/takima/temporalpractice/signals/InventoryWorkflow.java
@@ -1,10 +1,10 @@
package io.takima.temporalpractice.signals;
-
-@WorkflowInterface
+// TODO : remove comments when starting the mastering signals exercise
+//@WorkflowInterface
public interface InventoryWorkflow {
- @WorkflowMethod
+// @WorkflowMethod
void run();
- @SignalMethod
+// @SignalMethod
void reserve(ConsumeSignal input);
}
diff --git a/src/main/java/io/takima/temporalpractice/signals/MSMain.java b/src/main/java/io/takima/temporalpractice/signals/MSMain.java
index 32daba5..4778edd 100644
--- a/src/main/java/io/takima/temporalpractice/signals/MSMain.java
+++ b/src/main/java/io/takima/temporalpractice/signals/MSMain.java
@@ -1,29 +1,35 @@
package io.takima.temporalpractice.signals;
+// TODO : remove comments when starting the mastering signals exercise
+//import io.temporal.client.WorkflowClient;
+//import io.temporal.client.WorkflowOptions;
-import static io.takima.temporalpractice.temporal.TemporalUtils.*;
-import static io.takima.temporalpractice.temporal.TemporalQueues.*;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
+//import static io.takima.temporalpractice.temporal.TemporalUtils.*;
+//import static io.takima.temporalpractice.temporal.TemporalQueues.*;
public class MSMain {
// Our inventory will contain 100 elements and we will send 100 signals, lets see how it goes
static int inventoryToDecrement = 100;
public static void main(String[] args) {
- var worker = FACTORY.newWorker(MASTERING_SIGNALS);
- worker.registerActivitiesImplementations(new InventoryActivityImpl(inventoryToDecrement));
- worker.registerWorkflowImplementationTypes(InventoryWorkflowImpl.class);
+// var worker = FACTORY.newWorker(MASTERING_SIGNALS);
+// worker.registerActivitiesImplementations(new InventoryActivityImpl(inventoryToDecrement));
+// worker.registerWorkflowImplementationTypes(InventoryWorkflowImpl.class);
- FACTORY.start();
+// FACTORY.start();
- var workflow = CLIENT.newWorkflowStub(
- InventoryWorkflow.class,
- WorkflowOptions.newBuilder().setTaskQueue(MASTERING_SIGNALS).setWorkflowId("inventory").build()
- );
- WorkflowClient.start(workflow::run);
+// var workflow = CLIENT.newWorkflowStub(
+// InventoryWorkflow.class,
+// WorkflowOptions.newBuilder().setTaskQueue(MASTERING_SIGNALS).setWorkflowId("inventory").build()
+// );
+// WorkflowClient.start(workflow::run);
try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor()) {
// Submit 100 tasks
for (int i = 1; i < inventoryToDecrement; i++) {
executor.submit(() -> {
- workflow.reserve(new ConsumeSignal(1));
+// workflow.reserve(new ConsumeSignal(1));
});
}
}
--
GitLab