refactor: factor code inside methods

deadlock-plugins/deadlock-extension/src/core/keycloakOAuth2DeviceFlowConnection.ts

@@ -95,7 +95,6 @@ export default class KeycloakOAuth2DeviceFlowConnection {
       });
       return Promise.resolve({ accessToken: this.accessToken, refreshToken: this.refreshToken });
     } catch (error) {
-      err(error);
       return Promise.reject(error);
     }
   }
@@ -152,21 +151,32 @@ export default class KeycloakOAuth2DeviceFlowConnection {
       userAuthenticationRequestResponseCode = userAuthenticationRequestResponse.status;
       switch (userAuthenticationRequestResponseCode) {
         case HttpStatusCode.BAD_REQUEST:
-          {
-            const badRequestResponse =
-              (await userAuthenticationRequestResponse.json()) as FailedAuthenticationReponseData;
-            log(`${badRequestResponse.error!}: ${badRequestResponse.error_description}`);
+          await this.handleCreateUserAuthenticationBadRequest(userAuthenticationRequestResponse);
+          break;
+        case HttpStatusCode.OK: {
+          await this.handleCreateUserAuthenticationSuccessRequest(userAuthenticationRequestResponse);
+          break;
+        }
+        default: {
+          throw new Error(`tokenIsValid: Unhandled HTTP status: ${userAuthenticationRequestResponseCode}`);
+        }
+      }
+    }
+  }
+
+  private async handleCreateUserAuthenticationBadRequest(userAuthenticationRequestResponse: Response) {
+    const badRequestResponse = (await userAuthenticationRequestResponse.json()) as FailedAuthenticationReponseData;
     const errorCode = TokenFetchErrorCode[badRequestResponse.error!];
     switch (errorCode) {
       case TokenFetchErrorCode.invalid_client:
       case TokenFetchErrorCode.invalid_grant:
       case TokenFetchErrorCode.unsupported_grant_type: {
+        err(`${badRequestResponse.error!}: ${badRequestResponse.error_description}`);
         throw new Error('createUserAuthentication: ' + errorCode);
       }
       case TokenFetchErrorCode.authorization_pending: {
-                // I have to keep this `await sleep` and the while in the same function context
         await sleep(this.waitDuration.getCurrentDuration());
-                continue;
+        break;
       }
       case TokenFetchErrorCode.slow_down: {
         this.waitDuration.increase();
@@ -178,19 +188,12 @@ export default class KeycloakOAuth2DeviceFlowConnection {
       }
     }
   }
-          break;
-        case HttpStatusCode.OK: {
+
+  private async handleCreateUserAuthenticationSuccessRequest(userAuthenticationRequestResponse: Response) {
     const successRequestResponse =
       (await userAuthenticationRequestResponse.json()) as SuccessfulAuthenticationResponseData;
     this.accessToken = successRequestResponse.access_token ?? '';
     this.refreshToken = successRequestResponse.refresh_token ?? '';
-          break;
-        }
-        default: {
-          throw new Error(`tokenIsValid: Unhandled HTTP status: ${userAuthenticationRequestResponseCode}`);
-        }
-      }
-    }
   }
 }